Comments on: 30 Proven Code Review Best Practices from Microsoft https://www.michaelagreiler.com/code-review-best-practices/?utm_source=rss&utm_medium=rss&utm_campaign=code-review-best-practices Sun, 15 Jan 2023 13:52:16 +0000 hourly 1 https://wordpress.org/?v=6.1.6 By: Dr. Michaela Greiler https://www.michaelagreiler.com/code-review-best-practices/#comment-69163 Thu, 12 Jan 2023 07:38:56 +0000 https://www.michaelagreiler.com/?p=801#comment-69163 In reply to Michele.

Hi Michele, thanks for your compliment. Appreciate it. I created an awesome code review checklists github repository. You can already find a couple of checklists. Also, feel free to add new ones that you deem good: https://github.com/mgreiler/awesome-code-review-checklists

]]> By: Dr. Michaela Greiler https://www.michaelagreiler.com/code-review-best-practices/#comment-69160 Thu, 12 Jan 2023 07:18:57 +0000 https://www.michaelagreiler.com/?p=801#comment-69160 In reply to Mark Haller.

Hi Mark, this information comes from studies on software inspection. Yet, also, when analyzing open-source software and asynchronous modern peer reviews, Peter Rigby found that the medium number of reviewers is 2. This represents self-selected reviewers. Here is a good article from Peter that mentions the 2 reviewer findings: Contemporary Peer Review in Action: Lessons from Open Source Developmenthttps://ieeexplore.ieee.org/abstract/document/6148202

]]> By: Mark Haller https://www.michaelagreiler.com/code-review-best-practices/#comment-68143 Fri, 16 Dec 2022 21:26:04 +0000 https://www.michaelagreiler.com/?p=801#comment-68143 you mention “Some studies suggest the code review best practice of adding only two active reviewers.”

can you cite these studies? I’d love to share this with my team.

]]> By: Michele https://www.michaelagreiler.com/code-review-best-practices/#comment-56446 Wed, 13 Jul 2022 16:29:42 +0000 https://www.michaelagreiler.com/?p=801#comment-56446 I am so pleased to have found your site. As a programmer analyst for over 30 years, from private sector companies to now higher education, I was wondering if you have specific checklists for programming languages, such as SQL and PL/SQL. Thank you

]]> By: Dr. Michaela Greiler https://www.michaelagreiler.com/code-review-best-practices/#comment-17202 Fri, 21 Aug 2020 05:58:54 +0000 https://www.michaelagreiler.com/?p=801#comment-17202 In reply to David.

Hey David, thanks for the feedback and for spotting my typo!

]]> By: David https://www.michaelagreiler.com/code-review-best-practices/#comment-17192 Thu, 20 Aug 2020 14:34:51 +0000 https://www.michaelagreiler.com/?p=801#comment-17192 Love this article! Here’s my code review comment. 🙂 You have a typo in “Nothing worth than…”, where I presume you meant to say “worse”.

]]> By: Dr. Michaela Greiler https://www.michaelagreiler.com/code-review-best-practices/#comment-471 Sun, 30 Jun 2019 19:49:37 +0000 https://www.michaelagreiler.com/?p=801#comment-471 In reply to Greg YEO.

Thanks! Awesome to read you liked it. Sure. I am more than happy if you reference it!

]]> By: Greg YEO https://www.michaelagreiler.com/code-review-best-practices/#comment-446 Wed, 26 Jun 2019 07:20:54 +0000 https://www.michaelagreiler.com/?p=801#comment-446 It’s nice article. It’s great resource to share to junior to let them know the purpose of review.

I’m preparing for developer’s session focusing on “Reduce task switching as it kills productivity”.
Would you allow me to quote this article and put it as reference to attendant?

]]> By: Dr. Michaela Greiler https://www.michaelagreiler.com/code-review-best-practices/#comment-352 Wed, 19 Jun 2019 19:12:45 +0000 https://www.michaelagreiler.com/?p=801#comment-352 In reply to Jay Thakkar.

Hi Jay, yes, very good point! Thanks for adding that!

]]> By: Jay Thakkar https://www.michaelagreiler.com/code-review-best-practices/#comment-156 Tue, 14 May 2019 19:25:18 +0000 https://www.michaelagreiler.com/?p=801#comment-156 A good read. One thing I did not see in there is one of the benefits of keeping the change small is that in the unlikely event you need to revert it, it is easier to do so.

Jay

]]>