Comments on: Measuring Code Review Quality through PR Rejections https://www.michaelagreiler.com/rejections-as-code-review-quality-metric/?utm_source=rss&utm_medium=rss&utm_campaign=rejections-as-code-review-quality-metric Sat, 25 Dec 2021 19:41:20 +0000 hourly 1 https://wordpress.org/?v=6.1.6 By: Tim King https://www.michaelagreiler.com/rejections-as-code-review-quality-metric/#comment-20600 Tue, 15 Dec 2020 17:29:11 +0000 https://www.michaelagreiler.com/?p=5294#comment-20600 This reminds me of a story—and I apologize that I don’t remember where I heard about it, and I probably also am remembering it completely wrong. In order to reduce its bug count, a software organization rewarded QA people for finding bugs and rewarded developers for fixing them. Very quickly, devs started to inject bugs into the code and then tell QA where to find them. Everyone went home happy.

What you measure, that’s what you’re likely to get.

I would be afraid that if we reward developers for rejecting PR’s, then the culture will start providing PRs that can be rejected on superfluous grounds, to make it look like everyone is becoming a much better code reviewer. But the end product won’t be any better, and business value will suffer.

]]> By: Peter Pezaris https://www.michaelagreiler.com/rejections-as-code-review-quality-metric/#comment-20038 Mon, 30 Nov 2020 15:58:28 +0000 https://www.michaelagreiler.com/?p=5294#comment-20038 Great perspective. An underrated factor in getting a team to work together efficiently is that the environment is a pleasant one that individuals WANT to work together within. Love this article!

]]>